Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: https://localhost:9080 404 Not Found in aio app run #324

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

shazron
Copy link
Member

@shazron shazron commented Nov 17, 2020

This was broken from PR #320
Reverting this specific parcel-bunder entryPoint change.

Accessing https://localhost:9080/index.html works, but this is a break in the existing workflow.

This is a parcel-bundler issue: parcel-bundler/parcel#1315 that has been fixed in parcel-bundler@2: parcel-bundler/parcel#3996
We are using parcel-bundler@1.

How Has This Been Tested?

npm test
aio app run

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron shazron mentioned this pull request Nov 17, 2020
10 tasks
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #324 (0243c32) into master (9f5250d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         1270      1270           
  Branches       208       208           
=========================================
  Hits          1270      1270           
Impacted Files Coverage Δ
src/lib/runDev.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5250d...0243c32. Read the comment docs.

@shazron shazron merged commit e339e57 into master Nov 17, 2020
@shazron shazron deleted the entrypoint-fix branch July 26, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant